Issue #4 Guava for public suffix #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation. This breaks Heritrix' HashCrawlMapper
…blic_suffix Conflicts: src/test/java/org/archive/net/PublicSuffixesTest.java
|
Haven't reviewed in detail, but this is great. One concern though, this removes a method from the public API, namely PublicSuffixes.getTopmostAssignedSurtPrefixRegex(). That probably means the version should bump up to 1.2.0-SNAPSHOT. The heritrix class org.archive.crawler.processor.HashCrawlMapper uses that method, so it will have to be rewritten at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces code for looking up public suffixes with similar code from Google Guava.
This change breakes one class in Heritrix: org.archive.crawler.processor.HashCrawlMapper
Should be easy to fix though.