Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of the 3.10 release, @khaeru and I noticed that the original PR to fix
PRICE_EMISSION
(address #723) has become a little cluttered with discussions of how to create a proper test for the calculation update. Meanwhile, @volker-krey suggested that we should just bring the fix tomain
and open a follow-up issue to create the test later. Thus, this PR adds all changes from #726 that seem to be necessary to fix the calculation and make the tests pass as they are.Caution
The error with the current calculation of
PRICE_EMISSION
went undetected so long because our tests were not stringent enough. Hence our initial insistence that #726 contain the exact kind of test to prevent the issue from coming up again. Such a test is missing from this PR on purpose, but that makes it incomplete in that sense. We need to maintain the sense of urgency that this test should be added as quickly as possible.The only reason we are considering merging this without the test is because both @OFR-IIASA and @yiyi1991 manually confirmed that this fix works on sufficiently complex scenarios.
How to review
developer (someone like the reviewer) will be able to understand what the code
does in the future.
PRICE_EMISSION
calculation is explained and needs updating, please share that.PR checklist