Avoid superfluous DB calls from facade #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #148, @meksor and I noted that there were always two calls to
validate_data
when adding data to aParameter
. This is superfluous, of course, and the culprit is in the core layer: inparameter.add()
, weadd_data()
, but then also setparameter._model.data
, which triggers anothervalidate_data()
run because that always fires when the attribute is set.This PR fixes that by setting
parameter._model
instead of just.data
, also for all other relevant optimization items. This significantly boosts their performance.