Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce run.get_by_id() #140

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Introduce run.get_by_id() #140

merged 1 commit into from
Jan 24, 2025

Conversation

glatterf42
Copy link
Member

The second part of cleaning up #101. This exposes the run.get_by_id() function to all remaining data layers as it is only used by run.clone() (see next clean up PR) in the data/server layers (and present already in the DB layer).

@glatterf42 glatterf42 added the enhancement New feature or request label Nov 28, 2024
@glatterf42 glatterf42 self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.0%. Comparing base (1c62638) to head (1b72176).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ixmp4/data/abstract/run.py 50.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #140   +/-   ##
=====================================
  Coverage   86.9%   87.0%           
=====================================
  Files        230     230           
  Lines       8162    8170    +8     
=====================================
+ Hits        7100    7112   +12     
+ Misses      1062    1058    -4     
Files with missing lines Coverage Δ
ixmp4/data/api/run.py 97.9% <100.0%> (+0.1%) ⬆️
ixmp4/server/rest/run.py 100.0% <100.0%> (ø)
ixmp4/data/abstract/run.py 80.8% <50.0%> (-1.4%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glatterf42 glatterf42 force-pushed the enh/run-remove-solution branch 2 times, most recently from ba074b7 to b0201c6 Compare December 19, 2024 12:42
@glatterf42 glatterf42 force-pushed the enh/run-remove-solution branch from b0201c6 to 48e1d4c Compare January 24, 2025 12:36
Base automatically changed from enh/run-remove-solution to main January 24, 2025 15:14
@glatterf42 glatterf42 merged commit c7ea1f3 into main Jan 24, 2025
13 checks passed
@glatterf42 glatterf42 deleted the enh/run-get-by-id branch January 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants