Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement growing message sequences for [] syntax #47

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Implement growing message sequences for [] syntax #47

wants to merge 14 commits into from

Conversation

calvertdw
Copy link
Member

@calvertdw calvertdw commented Jan 10, 2025 •
edited
Loading

TODO:

  • Add ensureCapacity to IDLSequence.Byte

@calvertdw calvertdw requested a review from ds58 January 10, 2025 18:07
ds58
ds58 reviewed Jan 13, 2025
View reviewed changes
eprosima-idl-parser/src/main/java/com/eprosima/idl/parser/typecode/MemberedTypeCode.java
Comment on lines +93 to +96
// TODO: there may be more type codes that are sequence-like
if (member.getTypecode() instanceof SequenceTypeCode || member.getTypecode() instanceof MapTypeCode)
if (member.getTypecode().getUnbounded())
return true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds58 ds58 ds58 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvertdw @ds58