Add remote connectivity constructor to ZEDImageSensor #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds58
commented
Apr 29, 2025
| @@ -470,4 +497,10 @@ private String getZEDErrorName(int errorCode) | |||
| default -> "UNKNOWN"; | |||
| }; | |||
| } | |||
|
|
|||
| private static int calculateBitrate(int width, int height, int fps) | |||
There was a problem hiding this comment.
returns ~8000 for 1920x1080@30
TomaszTB
approved these changes
Apr 29, 2025
Comment on lines
110
to
111
| if (slInputType != SL_INPUT_TYPE_STREAM) | ||
| throw new RuntimeException("Invalid SL_INPUT_TYPE for called constructor (must be SL_INPUT_TYPE_STREAM)"); |
There was a problem hiding this comment.
Why not just remove the parameter from the constructor?
There was a problem hiding this comment.
Yes, good idea. Ive done that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.