Make the source compile with SIP-56 match types, for Scala 3.4.#286
Open
sjrd wants to merge 1 commit intoiheartradio:masterfrom
Open
Make the source compile with SIP-56 match types, for Scala 3.4.#286sjrd wants to merge 1 commit intoiheartradio:masterfrom
sjrd wants to merge 1 commit intoiheartradio:masterfrom
Conversation
Refine the definition of `EnumerationUtil.Aux` to make it comply with the legal match types of SIP-56. Although weird, it is the "standard" trick for extracting enumeration Value's uner SIP-56. Refine the result type of `EnumerationReader.findEnumValue` to be path-dependent instead of using the match type. It is strictly more precise.
|
OMG, I didn't even know this syntax was possible |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refine the definition of
EnumerationUtil.Auxto make it comply with the legal match types of SIP-56. Although weird, it is the "standard" trick for extracting enumeration Value's uner SIP-56.Refine the result type of
EnumerationReader.findEnumValueto be path-dependent instead of using the match type. It is strictly more precise.Ref scala/improvement-proposals#65, scala/scala3#18262