Skip to content

Small opcode optimisation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Small opcode optimisation #14

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e122fdc
allow providing an onError callable that is called on every error
igorw Sep 20, 2014
368ab31
:tada: dummy commit with data :
PierreAntoineGuillaume Jan 31, 2020
8f25d57
:tada: we move the code outside of the catch block :
PierreAntoineGuillaume Jan 31, 2020
f403c44
We replace "if (!$retries) { ... } $retries--" with "if (!$retries--)…
PierreAntoineGuillaume Jan 31, 2020
72e0aa3
We invert the if condition, now if $retries is non-zero we goto begin…
PierreAntoineGuillaume Jan 31, 2020
281c0c2
We transform the 'if condition goto' which does two jumps into a do .…
PierreAntoineGuillaume Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/retry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,18 @@

class FailingTooHardException extends \Exception {}

function retry($retries, callable $fn)
function retry($retries, callable $fn, callable $onError = null)
{
beginning:
try {
return $fn();
} catch (\Exception $e) {
if (!$retries) {
throw new FailingTooHardException('', 0, $e);
do
{
try {
return $fn();
} catch (\Exception $e) {}
if ($onError) {
$onError($e);
}
$retries--;
goto beginning;
}
while ($retries--);
throw new FailingTooHardException('', 0, $e);
}