Allow multiple aspect ratios

[mohammednasser-32]

Fixes #230

Add support for validating multiple aspect ratios, as done for content types, like:

validates :avatar, aspect_ratio: [:square, :portrait, :is_16_9]

[mohammednasser-32]

Hey @Mth0158, the tests are failing for one case minitest (3.2, rails_7_1, mini_magick)
However it is passing locally when running BUNDLE_GEMFILE=gemfiles/rails_7_1.gemfile bundle exec rake test, using ruby 3.2 and changing metadata to use DEFAULT_IMAGE_PROCESSOR (mini_magick)
Do you know how can I reproduce the error to solve it?

[Mth0158]

Hi @mohammednasser-32,
I'll correct the test once I am finished refactoring the metadata.rb file, so no worries, on that point :)

[Mth0158]

FYI you are making breaking changes to the gem (deleting error messages), you should try to not make such breaking changes. Because when we release for change people will have to change their own messages to make the gem work.

You could for example keep the messages as they are for the :with option, but add a new one for the :in option (a bit like :in content_type). This will also be better in term of UX for users since they have a better understanding of the error they are getting :)

[mohammednasser-32]

@Mth0158 yes right, sorry for the mess..I thought we need to make it similar to content_type (only content_type_invalid is there)
I pushed another approach

[Mth0158]

No worries, let me know when it's ready for reviewing :)

[mohammednasser-32]

It is 😅 feel free to review it and let me know if further changes are needed..thanks!

[Mth0158]

Hi @mohammednasser-32,
I was quite busy last week, I'll probably have time to do your review this week, I'll let you know once it's reviewed :)

[mohammednasser-32]

@Mth0158 just a friendly reminder whenever you have the time 🙏😄

[Mth0158]

Thanks for the PR,
Overall it is a nice work, however I think your code could be more readable in the validator, it's hard to follow what is happening, I think it's mostly due to your method naming. Maybe try to spend some time improving this? The rest is ok 👍

[mohammednasser-32]

@Mth0158 Thank you for the review 🙏 looking at the code again and you are absolutely right 😅
did some refactoring and renaming here..please let me know if more changes are needed, thank you

[mohammednasser-32]

Thanks again for the reveiw! added the changes and rebased

[Mth0158]

@mohammednasser-32 better adding new correction commits rather than rebasing the whole thing, it makes the review process quite difficult because I have to start over every time :/
Not rebasing would also not make the review comments "Outdated" which is easier to review :). Plus it does things like:

But no worries I'll review it like this, no need to change things now.

[Mth0158]

Thanks @mohammednasser-32 for the revamp. But I think there is still room for improvement, I think after this one we are good to go to merge though ;)

[mohammednasser-32]

Thank you again and sorry for how messy this turned 😅
appreciate your review and comments...changes applied

[Mth0158]

Hi @mohammednasser-32!

Thanks again for your hard work! The PR is a great addition to the gem ✌️