Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

196 rails default validation options missing from errors #218

Conversation

Mth0158
Copy link
Collaborator

@Mth0158 Mth0158 commented Nov 20, 2023

Closes #196

This PR includes 2 commits:

  • ab567ad: This commit have a lot a files changed because I had to create a lot of boilerplate to test it properly, it only impacts a few production features =>
    • The error_handler.rb file becomes the Errorable concern and gets a few upgrade to adress Rails default validation options missing from errors #196
    • The attached validator now does not accept the :allow_nil and :allow_blank options since it does not make sense to have these options with this validator
  • 5a85ba7: A short commit that defines our validator concerns at the gem level instead that the global level

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Nov 20, 2023

@igorkasyanchuk I would like to merge the #217 PR before this one though :)

@Mth0158 Mth0158 force-pushed the 196-rails-default-validation-options-missing-from-errors branch from 5a85ba7 to 5fbf2c3 Compare November 21, 2023 10:34
@Mth0158 Mth0158 removed the request for review from igorkasyanchuk November 21, 2023 10:34
@Mth0158 Mth0158 force-pushed the 196-rails-default-validation-options-missing-from-errors branch from 5fbf2c3 to 3a30125 Compare November 21, 2023 10:36
@Mth0158 Mth0158 merged commit 518ff10 into igorkasyanchuk:master Nov 22, 2023
20 checks passed
@Mth0158 Mth0158 deleted the 196-rails-default-validation-options-missing-from-errors branch November 22, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails default validation options missing from errors
1 participant