Change language menu's location to top right#2373
Change language menu's location to top right#2373melina-marjani wants to merge 6 commits intoifmeorg:mainfrom
Conversation
|
Looks like there's some linting errors on the JS side: https://app.circleci.com/pipelines/github/ifmeorg/ifme/2712/workflows/e229fdc6-a27d-4d8d-8b98-96fd4279dd42/jobs/17421 Running |
|
|
||
| create_table "allyships", force: :cascade do |t| | ||
| t.integer "user_id" | ||
| t.datetime "created_at", precision: nil |
There was a problem hiding this comment.
Let's omit this file's changes from this PR!
| @@ -344,5 +344,9 @@ | |||
| { | |||
| "name": "Ezeliora Godsfavour", | |||
| "link": "https://github.com/favy-codez" | |||
There was a problem hiding this comment.
Let's omit this as well since you have this in another PR!
|
Can you rebase this PR from main and remove the unnecessary commits? Thanks 🙏 |
melina-marjani
force-pushed
the
change-lang-menu-location1
branch
from
d6c20d7 to
f05f057
Compare
melina-marjani
force-pushed
the
change-lang-menu-location1
branch
from
f05f057 to
9b8a247
Compare
Removed unnecessary commits (trying to merge 4 commits now) and fixed the yarn lint error mentioned above. Please let me know if you want me to change anything or combine any commits! |
…locale value in the component
|
Hey, how are things going with resolving the rspec test failures? Let me know if you need any help! |
2 participants
Description
This PR changes the location of the dropdown menu from the bottom left to the top right. The language dropdown's styling has been modified to fit the navigation bar. Functionality has been tested.
Corresponding Issue
This addresses the issue #2322
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!