Conversation
Created unit test cases for each of the four functions mentioned in the github issue.
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
Member
|
I'm seeing there are linting errors, if you scroll down here to your failing job: |
Member
|
Any updates here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive unit tests for utility functions in client/app/utils/index.js.
More Details
This test suite covers all four exported utility functions: randomString, setCsrfToken, getPusher, and renderContent.
randomString
setCsrfToken
getPusher
renderContent
Corresponding Issue
Attempted to complete #2128
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!