Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
FenjuFu
left a comment
There was a problem hiding this comment.
Thanks for the PR! The footer additions look good — the iconHtml fallback in Footer.astro is clean and HF/ModelScope are correctly added to both the "Related Sites" column and the social bar.
One thing needs to be addressed before merge:
Unrelated change: header GitHub button is removed. In src/navigation.ts, headerData.actions is changed from the GitHub CTA to actions: [], which removes the "GitHub" button from the top navigation. This isn't part of "add Hugging Face and ModelScope links to footer" and looks unintended. Could you restore it?
actions: [
{
text: 'GitHub',
href: 'https://github.com/iflytek',
target: '_blank',
},
],Two minor notes (optional):
.cache/project-stats.jsongot swept into the commit — please revert that file so the diff stays focused on the feature.- The inline HF/ModelScope SVGs are generic placeholders (smiley / concentric circles) rather than the real brand marks. Fine to merge as-is, but swapping in the actual logos later would look more polished.
Once the header actions is restored I'll merge. Thanks!
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Thanks @FenjuFu F |
Confirmed with author: the header GitHub button removal is intentional (it overlapped on mobile), and GitHub remains accessible via the footer links and social icon. Dismissing — good to merge.
|
Thanks for the explanation @dongjiang1989 — that makes sense. GitHub is still reachable via the footer links and the social icon, so moving it out of the header to fix the mobile overlap is reasonable. Merging now. 👍 |
FenjuFu
left a comment
There was a problem hiding this comment.
Confirmed the header GitHub button removal is intentional (mobile overlap fix) and GitHub stays reachable via the footer. Footer additions look good. Approving.
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Summary
https://huggingface.co/iFlytekOpenSource) and ModelScope (https://modelscope.cn/organization/iflytek) links to the footer "Related Sites" columnactions→[])