Skip to content

feat: add Hugging Face and ModelScope links to footer #42

Merged
FenjuFu merged 3 commits into
mainfrom
add-links
Jun 30, 2026
Merged

feat: add Hugging Face and ModelScope links to footer #42
FenjuFu merged 3 commits into
mainfrom
add-links

Conversation

@dongjiang1989

@dongjiang1989 dongjiang1989 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Summary

  • Add Hugging Face (https://huggingface.co/iFlytekOpenSource) and ModelScope (https://modelscope.cn/organization/iflytek) links to the footer "Related Sites" column
  • Add Hugging Face and ModelScope inline SVG icons to the social icon bar
  • Remove GitHub action button from header (actions[])
  • Change readme and changelog md

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
website Ready Ready Preview, Comment Jun 30, 2026 9:18am

@FenjuFu FenjuFu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The footer additions look good — the iconHtml fallback in Footer.astro is clean and HF/ModelScope are correctly added to both the "Related Sites" column and the social bar.

One thing needs to be addressed before merge:

Unrelated change: header GitHub button is removed. In src/navigation.ts, headerData.actions is changed from the GitHub CTA to actions: [], which removes the "GitHub" button from the top navigation. This isn't part of "add Hugging Face and ModelScope links to footer" and looks unintended. Could you restore it?

  actions: [
    {
      text: 'GitHub',
      href: 'https://github.com/iflytek',
      target: '_blank',
    },
  ],

Two minor notes (optional):

  • .cache/project-stats.json got swept into the commit — please revert that file so the diff stays focused on the feature.
  • The inline HF/ModelScope SVGs are generic placeholders (smiley / concentric circles) rather than the real brand marks. Fine to merge as-is, but swapping in the actual logos later would look more polished.

Once the header actions is restored I'll merge. Thanks!

Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989

Copy link
Copy Markdown
Contributor Author

Unrelated change: header GitHub button is removed.

Thanks @FenjuFu F
This change was anticipated. The GitHub button was causing display overlap on mobile devices, so we've moved it from the header navigation bar to an icon in the footer instead.

@FenjuFu FenjuFu dismissed their stale review June 30, 2026 09:28

Confirmed with author: the header GitHub button removal is intentional (it overlapped on mobile), and GitHub remains accessible via the footer links and social icon. Dismissing — good to merge.

@FenjuFu

FenjuFu commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Thanks for the explanation @dongjiang1989 — that makes sense. GitHub is still reachable via the footer links and the social icon, so moving it out of the header to fix the mobile overlap is reasonable. Merging now. 👍

@FenjuFu FenjuFu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the header GitHub button removal is intentional (mobile overlap fix) and GitHub stays reachable via the footer. Footer additions look good. Approving.

@FenjuFu FenjuFu merged commit 35258e4 into main Jun 30, 2026
12 checks passed
@dongjiang1989 dongjiang1989 deleted the add-links branch June 30, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants