Skip to content

feat(promotion): improve promotion review dashboard#555

Merged
dongmucat merged 1 commit into
mainfrom
feature/promotion-review-optimization
Jun 24, 2026
Merged

feat(promotion): improve promotion review dashboard#555
dongmucat merged 1 commit into
mainfrom
feature/promotion-review-optimization

Conversation

@dongmucat

Copy link
Copy Markdown
Collaborator

Summary

  • enrich pending promotion review cards with skill metadata, submitter, package size, downloads, and stars
  • keep approved/rejected views as tables and add reviewed-time sorting from the table header
  • extend promotion list API with status and reviewedAt sort params, plus OpenAPI/generated client updates
  • add backend, frontend unit, and Playwright E2E coverage for sorting and enriched pending data

Validation

  • make typecheck-web
  • make lint-web
  • make test-frontend
  • make test-backend-app
  • cd web && pnpm exec playwright test e2e/promotions-review.spec.ts
  • NO_PROXY=localhost,127.0.0.1,::1 no_proxy=localhost,127.0.0.1,::1 make test-e2e-frontend
  • make staging: backend image/frontend build/server healthy passed; local ~/Documents bind mount blocked nginx template read, so web health + smoke test were completed with a temporary /tmp mount override. Smoke result: 15 passed, 0 failed.

Signed-off-by: dongmucat <1127093059@qq.com>
@dongmucat dongmucat force-pushed the feature/promotion-review-optimization branch from 7f541aa to e501be9 Compare June 24, 2026 01:28
@dongmucat dongmucat merged commit c25f950 into main Jun 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant