Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to log time spent in S3Storage calls #8533

Merged
merged 5 commits into from
Feb 14, 2025
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion ietf/doc/storage_backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,37 @@ class CustomS3Storage(S3Storage):

def __init__(self, **settings):
self.in_flight_custom_metadata: Dict[str, Dict[str, str]] = {}
return super().__init__(**settings)
super().__init__(**settings)

def get_default_settings(self):
# add a default for the ietf_log_blob_timing boolean
return super().get_default_settings() | {"ietf_log_blob_timing": False}

def _save(self, name, content):
# Only overriding this to add the option to time the operation
before = timezone.now()
result = super()._save(name, content)
rjsparks marked this conversation as resolved.
Show resolved Hide resolved
if self.ietf_log_blob_timing:
dt = timezone.now() - before
log(f"S3Storage timing: _save('{name}', ...) for {self.bucket_name} took {dt.total_seconds()} s")
return result

def _open(self, name, mode="rb"):
# Only overriding this to add the option to time the operation
before = timezone.now()
result = super()._open(name, mode)
if self.ietf_log_blob_timing:
dt = timezone.now() - before
log(f"S3Storage timing: _open('{name}', ...) for {self.bucket_name} took {dt.total_seconds()} s")
return result

def delete(self, name):
# Only overriding this to add the option to time the operation
before = timezone.now()
super().delete(name)
if self.ietf_log_blob_timing:
dt = timezone.now() - before
log(f"S3Storage timing: delete('{name}') for {self.bucket_name} took {dt.total_seconds()} s")

def store_file(
self,
Expand Down