chore: more comments

ietf-tools · Feb 5, 2025 · 0696fc9 · 0696fc9
1 parent c09699c
commit 0696fc9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/ietf/doc/factories.py b/ietf/doc/factories.py
@@ -285,7 +285,7 @@ class Meta:
 
     type = 'added_comment'
     by = factory.SubFactory('ietf.person.factories.PersonFactory')
-    doc: Any = factory.SubFactory(DocumentFactory)
+    doc: Any = factory.SubFactory(DocumentFactory)  # `Any` to appease mypy when a subclass overrides doc
     desc = factory.Faker('sentence',nb_words=6)
 
     @factory.lazy_attribute

diff --git a/ietf/ipr/tests.py b/ietf/ipr/tests.py
@@ -726,7 +726,7 @@ def test_notify_generic(self):
         self.assertIn(f'{settings.IDTRACKER_BASE_URL}{urlreverse("ietf.ipr.views.showlist")}', get_payload_text(outbox[1]).replace('\n',' '))
 
     def send_ipr_email_helper(self) -> tuple[str, IprEvent, HolderIprDisclosure]:
-        ipr = HolderIprDisclosureFactory.create()
+        ipr = HolderIprDisclosureFactory.create()  # call create() explicitly so mypy sees correct type
         url = urlreverse('ietf.ipr.views.email',kwargs={ "id": ipr.id })
         self.client.login(username="secretary", password="secretary+password")
         yesterday = date_today() - datetime.timedelta(1)

diff --git a/ietf/meeting/tests_views.py b/ietf/meeting/tests_views.py
@@ -2124,6 +2124,7 @@ def create_timeslots_url(meeting):
     @staticmethod
     def create_bare_meeting(number=120) -> Meeting:
         """Create a basic IETF meeting"""
+        # Call create() explicitly so mypy sees the correct type
         return MeetingFactory.create(
             type_id='ietf',
             number=number,