Fix parsing of new blocks in state#91
Open
RafaelWO wants to merge 1 commit into
Open
Conversation
This change fixes the parsing of a Terraform state by only creating new blocks if the line starts with `# ` - note the space after the hash. This is required because the state can contain arbitrary data, e.g. the raw content of a file (from `data.local_file`, which can start with a `#` - this is what happened in my case. I hope that hash + whitespace will only occur if a new block starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the parsing of a Terraform state by only creating new blocks if the line starts with
#- note the space after the hash.This is required because the state can contain arbitrary data, e.g. the raw content of a file (from
data.local_file, which can start with a#- this is what happened in my case.I hope that hash + whitespace will only occur if a new block starts.
Background
When I ran the TUI on one of my Terraform modules, I only got the following message in the output before it exited:
After closing the repo and running the app in a debugger, I could get the actual exception:
(Maybe the full exception could be printed - at least in the debug logs?)
This happened due to the current
linein the state file beingand the app failed to parse it as a new block - obviously.
With the proposed fix, the TUI app works perfectly on my module of interest 🙂