Skip to content

Conversation

@ltackett
Copy link
Contributor

Enables passing messages to application.view.scroll_view via OSC to navigate the cursor.

@ltackett
Copy link
Contributor Author

Not totally stoked on the location of this handler. In the LOM it sits under Application.View. 🤷🏻‍♂️

@ideoforms
Copy link
Owner

Hi @ltackett, sorry for the slow reply on this!

I like the functionality, but API-wise, I think this fits neatly under the existing /live/view namespace - /live/view/scroll_view would be a good location for it. If you are able to update the endpoint and docs appropriately, I'll then get this merged. Thanks.

Copy link
Owner

@ideoforms ideoforms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the functionality, but API-wise, I think this fits neatly under the existing /live/view namespace - /live/view/scroll_view would be a good location for it. If you are able to update the endpoint and docs appropriately, I'll then get this merged. Thanks.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants