Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neumann BC in the LinearFV system #30146 #30147

Draft
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

freiler
Copy link
Contributor

@freiler freiler commented Mar 19, 2025

Closes #30146

@freiler freiler requested a review from lindsayad as a code owner March 19, 2025 22:25
@freiler freiler marked this pull request as draft March 19, 2025 22:26
@grmnptr grmnptr self-assigned this Mar 19, 2025
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 438a673 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 438a673 wanted to post the following:

Framework coverage

051868 #30147 438a67
Total Total +/- New
Rate 85.29% 85.29% -0.00% -
Hits 109056 109055 -1 0
Misses 18809 18810 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

freiler added 3 commits March 20, 2025 11:15
… or a gradient extrapolation. Fixes issues with LinearFVDiffusion::computeBoundaryRHSContribution(), where for non-orthogonal meshes with Neumann BC an extra contribution was added that resulted in wrong results.
…der for orthogonal meshes and first order for non-orthogonal meshes
…nality. Obtain second order convergence for 2d diffusion in non-orthogonal meshes
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on 316740c wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/30147/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 92e4cfa047ab08e7fab70c0d4c297b858ba6905d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinearFV Neumann BC
3 participants