Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valgrind failure in STM #30142

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Conversation

zachmprince
Copy link
Contributor

Reason

Closes #30141

Design

There was some faulty logic in the SobolReporter that was causing it to output second-order indices even when they didn't exist. After fixing this, I realized there really should be a proper unit test to do a non-resampled sobol computation, so I added that.

In preparation of a new testing paradigm for examples. I renamed the test spec for the workshop so it wouldn't be run by default. Instead it would be run in something like this recipe: https://civet.inl.gov/job/2758375/

Impact

Non-buggy code.

@zachmprince zachmprince self-assigned this Mar 19, 2025
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on a977d32 wanted to post the following:

View the site here

This comment will be updated on new commits.

@loganharbour
Copy link
Member

Optimization failure is unrelated. Waiting on examples in https://civet.inl.gov/job/2759912/

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on a977d32 wanted to post the following:

Framework coverage

8960f3 #30142 a977d3
Total Total +/- New
Rate 85.28% 85.28% +0.00% -
Hits 109358 109359 +1 0
Misses 18883 18882 -1 0

Diff coverage report

Full coverage report

Modules coverage

Stochastic tools

8960f3 #30142 a977d3
Total Total +/- New
Rate 90.64% 90.64% - 100.00%
Hits 8104 8104 - 2
Misses 837 837 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@loganharbour loganharbour marked this pull request as ready for review March 20, 2025 03:01
@loganharbour loganharbour requested a review from grmnptr as a code owner March 20, 2025 03:01
@loganharbour loganharbour merged commit 92e4cfa into idaholab:next Mar 20, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valgrind error in SobolReporter
4 participants