Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more coverage to the batch MG action #30134

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented Mar 18, 2025

refs #29800

I missed the hole in coverage in my review
this is rebased on your PR @miaoyinb, which will be merged first

@GiudGiud GiudGiud requested a review from miaoyinb March 18, 2025 23:41
@GiudGiud GiudGiud self-assigned this Mar 18, 2025
@GiudGiud GiudGiud marked this pull request as ready for review March 18, 2025 23:42
@GiudGiud GiudGiud requested a review from lindsayad as a code owner March 18, 2025 23:42
@moosebuild
Copy link
Contributor

moosebuild commented Mar 19, 2025

Job Documentation, step Docs: sync website on 8382711 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Distributed mesh sweep evens on 4486f50 : invalidated by @miaoyinb

@moosebuild
Copy link
Contributor

Job Distributed mesh sweep odds on 4486f50 : invalidated by @miaoyinb

@moosebuild
Copy link
Contributor

Job Non unity build on 4486f50 : invalidated by @miaoyinb

@moosebuild
Copy link
Contributor

Job OpenMPI on 4486f50 : invalidated by @miaoyinb

@moosebuild
Copy link
Contributor

moosebuild commented Mar 19, 2025

Job Coverage, step Generate coverage on 8382711 wanted to post the following:

Framework coverage

8960f3 #30134 838271
Total Total +/- New
Rate 85.28% 85.30% +0.03% -
Hits 109358 109394 +36 0
Misses 18883 18847 -36 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Mar 19, 2025

Rebased on next

@GiudGiud
Copy link
Contributor Author

see the coverage report now, as it will be removed if next does not have a coverage report

@GiudGiud GiudGiud merged commit 2af7c26 into idaholab:next Mar 20, 2025
50 of 53 checks passed
@GiudGiud GiudGiud deleted the PR_cov_batch branch March 20, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants