Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase size of factorization space on test that sometimes fail #30128

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Increase size of factorization space on test that sometimes fail #30128

merged 1 commit into from
Mar 20, 2025

Conversation

GiudGiud
Copy link
Contributor

with

PC failed due to FACTOR_OUTMEMORY
refs #30127

Alex used these options to solve a similar error message on a TMAP case. I suspect the fix works equally well here

@GiudGiud GiudGiud self-assigned this Mar 18, 2025
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 847b4b8 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 847b4b8 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

Thoughts on refreshing the test suite 10 times to see if the test ever fails?

@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

2nd time

@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

3rd time

@moosebuild
Copy link
Contributor

Job Modules parallel on 847b4b8 : invalidated by @GiudGiud

@idaholab idaholab deleted a comment from moosebuild Mar 18, 2025
@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

NS passed 4th time

@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

6th

@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

7th still smooth

@moosebuild
Copy link
Contributor

Job Modules parallel on 847b4b8 : invalidated by @GiudGiud

8th unrelated failure

@moosebuild
Copy link
Contributor

Job Modules on 847b4b8 : invalidated by @GiudGiud

9th

roystgnr
roystgnr approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@roystgnr roystgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth a shot, at least. "percentage increase in the estimated working space" looks like a good choice of knob to be tweaking, though I can't imagine how Alex hit upon that in the first place.

@moosebuild
Copy link
Contributor

Job Modules parallel on 847b4b8 : invalidated by @GiudGiud

10th and final

@GiudGiud GiudGiud marked this pull request as ready for review March 19, 2025 19:48
@GiudGiud
Copy link
Contributor Author

NS passed again

@GiudGiud GiudGiud merged commit 5094a78 into idaholab:next Mar 20, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roystgnr roystgnr roystgnr approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

@grmnptr grmnptr Awaiting requested review from grmnptr grmnptr is a code owner

Assignees

@GiudGiud GiudGiud

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiudGiud @moosebuild @roystgnr