Fix fixed point end/begin restoring and execution issues #30119
+26
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation, step Docs: sync website on aa60622 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on aa60622 wanted to post the following: Framework coverageNo coverage report(s) were found for the base commit 79f9bd5. Modules coverageNo coverage report(s) were found for the base commit 79f9bd5. Full coverage reportsReports
This comment will be updated on new commits. |
lindsayad
approved these changes
Mar 18, 2025
|
Job Controlled apps on 7391296 : invalidated by @GiudGiud fixed now? |
…those once Restoring erases any progress on fixed point begin, and does nothing on end closes idaholab#30116
effectively reported in idaholab#28932, which is a PR fixes a true time step end/begin option requested in idaholab#28930
|
Rebased to get just the relevant commits showing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #30116
ignore the Qp commit, this is just because I based this on a different branch