-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to de-register syntax from MOOSE App #30114
Conversation
Job Precheck, step Clang format on 8f7d318 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Job Documentation, step Docs: sync website on a892754 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage, step Generate coverage on a66bc55 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
I've been wishing for this for a long time. Thanks for adding this capability. I think it would be nice to add a test case, and I feel like it's not too difficult though. You can register a test object called "DeregisterMe", and de-register it in another translation unit. Then you can create a test case using regular expression to search for the error message (on trying to find DeregisterMe). |
Oh sorry, I left the comment without reading the file changes. This PR is for de-registering action syntax instead of de-registering objects from the registry... |
oups sorry for the letdown. We can have a feature request for objects, I agree we could use that too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should at the very least have a unit test. There's unit tests for Syntax.
I'm not sure how I feel about this, though. I think just allowing the erasure of anything might be dangerious
If we erase a syntax, any input with that syntax should error. So it's fairly safe. And if they replace the actions for that syntax, that is already allowed and SAM does this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing unit build. Otherwise, good
works now |
Parallel modules failure unrelated |
refs #30113
this one is a tad tricky to test imo. I d have to mess with the TestApp.C which is a little unorthodox?
I ll let the reviewer decide if we want coverage on this or if it's simple enough