Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force postprocessor functors to be pre-aux in FunctorAux #30051

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Force postprocessor functors to be pre-aux in FunctorAux #30051

merged 2 commits into from
Mar 20, 2025

Conversation

NamjaeChoi
Copy link
Contributor

Closes #30050.

@NamjaeChoi
Copy link
Contributor Author

Closing as FunctorAux can do the purpose.

@NamjaeChoi NamjaeChoi closed this Mar 7, 2025
@NamjaeChoi NamjaeChoi deleted the postprocessor_aux branch March 7, 2025 02:41
@moosebuild
Copy link
Contributor

moosebuild commented Mar 7, 2025 •
edited
Loading

Job Documentation, step Docs: sync website on a4158a3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@NamjaeChoi NamjaeChoi restored the postprocessor_aux branch March 17, 2025 20:45
@NamjaeChoi
Copy link
Contributor Author

Reopening because FunctorAux cannot resolve dependencies.

@NamjaeChoi NamjaeChoi reopened this Mar 17, 2025
@GiudGiud
Copy link
Contributor

how about adding a few lines in FunctorAux to detect whether any PP is being executed too late?

@GiudGiud
Copy link
Contributor

I have some similar checking in FunctorIC that you can port over

@NamjaeChoi
Copy link
Contributor Author

Have users set force_preaux?

@GiudGiud
Copy link
Contributor

until we can do better yeah

@NamjaeChoi
Copy link
Contributor Author

Sounds good.

@NamjaeChoi NamjaeChoi changed the title Move PostprocessorAux to framework Force postprocessor functors to be pre-aux in FunctorAux Mar 17, 2025
@NamjaeChoi
Copy link
Contributor Author

I believe some tests will hit this error.

@GiudGiud
Copy link
Contributor

Test failures unrelated

@GiudGiud GiudGiud self-assigned this Mar 20, 2025
@GiudGiud
Copy link
Contributor

Thanks for the patch! Making functors a little safer is good

@GiudGiud GiudGiud merged commit 059f29f into idaholab:next Mar 20, 2025
48 of 51 checks passed
@NamjaeChoi NamjaeChoi deleted the postprocessor_aux branch March 20, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud GiudGiud approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

Assignees

@GiudGiud GiudGiud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move PostprocessorAux to framework
3 participants
@NamjaeChoi @moosebuild @GiudGiud