Add fluid properties for lead lithium eutectic #29989
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
commented
Mar 17, 2025
| ADReal c_from_v_e(const ADReal & v, const ADReal & e) const override; | ||
|
|
||
| private: | ||
| /// Melting temperature of 2LiF-BeF2 |
There was a problem hiding this comment.
Suggested change
| /// Melting temperature of 2LiF-BeF2 | |
| /// Melting temperature of lead lithium |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bibliography obtained with chatGPT o3 deep research
all code generated with chatGPT o3-mini-high
This is going to require an in-depth review. The code runs and tests fine, but we should be wary of every property used, and of the references.
Notably, while the doi seem fine, I think the titles of the references are modified from the original text