-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update seacas to 2025-02-27 release #29984
Conversation
8b734e4
to
e0946e9
Compare
@loganharbour Looks like the Versioner output decided to format the "to hash" for this change (067e220) as a number in scientific notation. Odd! |
Job Documentation, step Docs: sync website on a0f0f33 wanted to post the following: View the site here This comment will be updated on new commits. |
e0946e9
to
55e2493
Compare
Job Coverage, step Generate coverage on a0f0f33 wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
55e2493
to
14a3651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to rebase due do #30042. otherwise, all good
Yeah - I just wanted to see how the testing shook out, since there were some failures last time that I wasn't sure where they were coming from. |
oh, sorry. wasn't a draft so I assumed you were good |
I think it was un-related, just double-checking. I'll ping you when libMesh goes in and I rebase. |
#29884 affects this PR as well. Depending on "who wins". But because the above PR changes the entire stack, yours will most likely make it in before mine. |
@milljm Given the exact content of this, I feel that this PR can be merged absolutely whenever. I know you've been waiting on that .GOV PR for a bit now. |
The only conflict I can think of, is the Because of the "changes everything" attribute of my PR, I feel we should do those sorts of merges while Next is locked down, as well as being able to merge such a PR early in the day. TLDR; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
14a3651
to
ad424b4
Compare
ad424b4
to
b58fac9
Compare
This also adds a missing ticket reference to the most-recent libmesh update hash changes
b58fac9
to
a0f0f33
Compare
@loganharbour this is ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go whenever you're ready
Refs #21665