fix: passkey signing process via qr code flow #3116
Merged
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-linus
changed the title
ice-linus
force-pushed
the
fix/login-reg-account-by-qrcode
branch
from
78062c3 to
f3752d6
Compare
ice-hades
approved these changes
Jan 16, 2026
ice-kreios
approved these changes
Jan 16, 2026
ice-morpheus
force-pushed
the
fix/login-reg-account-by-qrcode
branch
3 times, most recently
from
7fc035a to
9baf12c
Compare
ice-morpheus
force-pushed
the
fix/login-reg-account-by-qrcode
branch
from
9baf12c to
c7d3e55
Compare
ice-tychon
approved these changes
Jan 16, 2026
ice-priapus
pushed a commit
that referenced
this pull request
Jan 16, 2026
## Description - Improved the passkey signing logic by introducing a method to resolve the relying party ID from the challenge. - Added error handling for invalid challenges to prevent UI crashes. - Implemented a method to clear the suggestion state on successful sign-in. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [x] Refactoring - [ ] Documentation - [ ] Chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change