fix: improve token info fetching logic in tokenMarketInfoIfAvailable #3115
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where tokenMarketInfoIfAvailableProvider would return null when the first-buy definition cache was missing, even if valid token market data existed in the analytics service. The fix ensures the provider always fetches and returns actual token market data when available, regardless of cache state.
Changes:
- Modified the conditional logic to always fetch token info from the analytics service first
- Returns token data if available from analytics, even when
hasTokenis false due to a cache miss - Only returns null when both the first-buy cache check fails AND no analytics data is available
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/app/features/tokenized_communities/providers/token_market_info_provider.r.dart
Outdated
Show resolved
Hide resolved
lib/app/features/tokenized_communities/providers/token_market_info_provider.r.dart
Outdated
Show resolved
Hide resolved
ice-morpheus
force-pushed
the
fix/token-market-info-provider
branch
from
1ab94f0 to
27ee543
Compare
ice-endymion
force-pushed
the
fix/token-market-info-provider
branch
from
27ee543 to
669c7a6
Compare
ice-endymion
force-pushed
the
fix/token-market-info-provider
branch
from
669c7a6 to
5efde92
Compare
ice-orion
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task ID
ION-5079
Type of Change