fix: handles error when loading followers in profile #3102
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-cerberus
requested review from
ice-evander,
ice-hades and
ice-orion
as code owners
ice-morpheus
force-pushed
the
fix-followers-profile-loading
branch
from
69657d7 to
9ddfe82
Compare
ice-orion
reviewed
Jan 15, 2026
| ).future, | ||
| ) as FutureOr<int?>; | ||
| } catch (error) { | ||
| return null; |
Contributor
There was a problem hiding this comment.
It will show incorrect data (0) instead of infinity loading, in case of exception, is it better / do we need to do that?
ice-orion
reviewed
Jan 15, 2026
| cache: false, | ||
| ); | ||
| } catch (sendError) { | ||
| relay.keys.first.unsubscribe(subscription.id); |
Contributor
There was a problem hiding this comment.
we unsubscribe in the finally block already, why do we need it here?
ice-morpheus
force-pushed
the
fix-followers-profile-loading
branch
17 times, most recently
from
8ac6247 to
80a4c2f
Compare
ice-morpheus
force-pushed
the
fix-followers-profile-loading
branch
from
80a4c2f to
a747545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional info
This is the uncaught exception happened before the fix:
Task ID
ION-5055
Type of Change