-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing syntax errors in multizone simple office semantic model. #709
Open
lazlop
wants to merge
16
commits into
ibpsa:issue591_addSemanticTags
Choose a base branch
from
anandkp92:issue591_semantics
base: issue591_addSemanticTags
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixing syntax errors in multizone simple office semantic model. #709
lazlop
wants to merge
16
commits into
ibpsa:issue591_addSemanticTags
from
anandkp92:issue591_semantics
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue591 add semantic tags
… issue591_semantics
@lazlop as per conversation during the meeting I updated Issue591 with the latest master version, so you can clone it on your fork and make updates there. Let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some syntax errors in the semantic model it would be good to fix while creating it. I fixed all the issues, so we can see examples of what needs to be fixed in the track changes.
Syntax corrections needed are roughly:
No quotes in node URIs (things after the colon)
we can replace things in the literal namespace with normal literals now! (literal:text to "text")
Make sure no periods are in the wrong places.
Can't use '/' character in URIs. Use qudt for units which has convention X-PER-Y or put in quotes.
Period only at the end of all triples, if there will be another predicate and object than have to use semicolon.
Make sure angle brackets don't get through like ref:name literal:<cdl_instance_name>_y
external references are generally for where a data source is external to the graph. References for zones and equipment aren't really external, we should discuss if we want to include them.
has external reference for equipment/zones is incorrect, not actually referencing the external reference but referencing itself.