-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue639 actuator travel #699
Open
terrancelu92
wants to merge
27
commits into
ibpsa:issue639_actuatorTravel
Choose a base branch
from
terrancelu92:issue639_actuatorTravel
base: issue639_actuatorTravel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue639 actuator travel #699
terrancelu92
wants to merge
27
commits into
ibpsa:issue639_actuatorTravel
from
terrancelu92:issue639_actuatorTravel
+412
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhblum, I have mainly uploaded the KPI code associated with the existing test cases. Additionally, I’ve included the content we discussed for both the existing and new test cases. testcase_kpi.py is a simple demonstration example.
Once we agree on the existing test cases, I will push the codse for the new test cases (for which I have already implemented a draft). The kpi_calculator.py contains some components related to the new test case, but I have not yet pushed the workflow for actuator tagging, including the parsing code and overwritten model block, for the new test case.
Thank you!
For existing testcases
New testcase (add workflow for actuator tagging)