Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue639 actuator travel #699

Open
wants to merge 27 commits into
base: issue639_actuatorTravel
Choose a base branch
from

Conversation

terrancelu92
Copy link
Contributor

@dhblum, I have mainly uploaded the KPI code associated with the existing test cases. Additionally, I’ve included the content we discussed for both the existing and new test cases. testcase_kpi.py is a simple demonstration example.
Once we agree on the existing test cases, I will push the codse for the new test cases (for which I have already implemented a draft). The kpi_calculator.py contains some components related to the new test case, but I have not yet pushed the workflow for actuator tagging, including the parsing code and overwritten model block, for the new test case.

Thank you!


  • For existing testcases

    • Calculation method for the KPI where we:
      • First scale both the x and y axis data to between 0 and 1 (y-axis based on the allowable range of the control signal indicated by BOPTEST, x-axis based on time period under analysis),
      • Then calculate the arc length and NOT do any additional normalization to a straight line (which would be equal to 1 anyway in this case),
      • And then average it over total number of signals (as we do now).
    • add normalization by number of actuators to kpi_calc and documentation (and sum to doc)
    • add config file to kpi directory specifying map for variables in existing test cases and use in kpi_calculator for these cases
    • add comments to kpi calc code
  • New testcase (add workflow for actuator tagging)

    • update overwrite block in IBPSA Modelica Library
    • update parser for pulling from model and adding to kpi.json
    • update kpi_calculator pulling from kpi.json

@terrancelu92 terrancelu92 requested a review from dhblum November 1, 2024 02:55
@terrancelu92 terrancelu92 marked this pull request as draft November 1, 2024 03:27
@terrancelu92 terrancelu92 marked this pull request as ready for review November 1, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants