Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue500 update data manager #645

Merged
merged 5 commits into from
May 14, 2024
Merged

Issue500 update data manager #645

merged 5 commits into from
May 14, 2024

Conversation

EttoreZ
Copy link
Contributor

@EttoreZ EttoreZ commented May 14, 2024

This PR addresses #500, a warning was added to the data/data_manager.py script if any of the weather variables present in data/categories.json is missing from wrapped.fum/resources/weather.csv.

@EttoreZ EttoreZ added the enhancement New feature or request label May 14, 2024
@EttoreZ EttoreZ requested a review from dhblum May 14, 2024 03:46
@EttoreZ EttoreZ self-assigned this May 14, 2024
Copy link
Collaborator

@dhblum dhblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EttoreZ I think this functionality should go in the method save_data_and_jsons since that is invoked when the csvs are moved to the FMU when compiling the test case and is when other similar warnings are shown to a test case developer if there are issues with the different files.

load_data_and_jsons is called when the test case docker container is deployed and the warning message will be lost among alot of other container deployment messages, not known to a typical boptest user (who is not a test case developer), and may not be displayed at all if the container is deployed in the background or a remote server (i.e. on aws).

releasenotes.md Outdated Show resolved Hide resolved
@EttoreZ
Copy link
Contributor Author

EttoreZ commented May 14, 2024

@dhblum thank you for the comments, they all make sense.

  • I moved the warning to the method _append_csv_data within save_data_and_jsons , which is where the .csv files are checked.
  • I updated the release notes according to the suggestion.

@dhblum dhblum enabled auto-merge May 14, 2024 16:46
@dhblum dhblum merged commit 71b5e01 into master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants