Fix GCC 15 build #114
Closed
Fix GCC 15 build #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyreld
reviewed
Aug 15, 2025
src/nvram.c
Outdated
| void (*rtas_print_event)(); | ||
| void (*cleanup_rtas_event)(); | ||
| struct rtas_event *(*parse_rtas_event)(char *, int); | ||
| void (*rtas_print_event)(FILE *, struct rtas_event *, int); |
Member
There was a problem hiding this comment.
If we are fixing function definitions to match those defined in librtasevent then rtas_print_event and cleanup_rtas_event both return int.
Member
|
@hramrach I need signed-off-by tags to officially pull these. |
Signed-off-by: Michal Suchanek <[email protected]>
Signed-off-by: Michal Suchanek <[email protected]>
The string is terminated by explicit NUL assignement below, use memcpy instead of strncpy. Signed-off-by: Michal Suchanek <[email protected]>
This was referenced Aug 28, 2025
Closed
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.