refactor: simplify cache, add support for mssql
#9938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
reviewed
Aug 27, 2024
cpcloud
reviewed
Aug 27, 2024
cpcloud
added
bug
|
Hmmm, I thought pre-commit hooks still ran when rebasing? Not sure how that formatting issue slipped through. Anyway, this should be good-to-go. |
cpcloud
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
.cache(). Abstracting things out to a generalRefCountedCacheled to some hard-to-follow code paths for no added benefit (we weren't using that class anywhere else, and there were no isolated tests for the functionality). Moving to a mixin in theBaseBackendmade the methods required a lot easier to follow.mssqlimplementation that was preventing support..cache()now fully works withmssql.Net decrease in LOC, while adding functionality and tests.
This change was motivated by #6195, which I'll add as a follow-up.