feat(ddl): disallow inserting by position, require source columns to be subset of target columns #11776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be ubset of target columns
github-actions
bot
added
tests
NickCrews
added
the
breaking change
NickCrews
changed the title
Contributor
Author
|
@deepyaman this is related to your upsert PR, if you want to give it a look. I don't think there is any ordering needed between the two, but I do think it would be great if this PR was included in the same release as that PR, so that the .upsert() API never goes through a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking, but probably not for a huge fraction of users (???).
Resolves #11731