Skip to content

blines on a terminal buffer #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
phanen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

blines on a terminal buffer #2419

phanen wants to merge 1 commit into from

Conversation

@phanen
Copy link
Contributor

@phanen phanen commented Nov 11, 2025 •
edited
Loading

Cursor won't resume to correct position after <CR>/<ESC>...
When you run blines on a terminal buffer.

I don't think this approach is good... just let u know we have this kind issue.

EDIT:
snacks.picker also have this issue... so maybe open an issue upstream then wait folke to solve/close it.

@ibhagwan
Copy link
Owner

ibhagwan commented Nov 11, 2025

I think the entire mode restoration code should probably be refactored and put somewhere like action_ post or win::post (gets called on both close and hide).

d7497da b19dabe

Not 100% sure if we wanna centralize/normalize cursor setting as well.

@ibhagwan ibhagwan mentioned this pull request Nov 23, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phanen @ibhagwan