Skip to content

Conversation

@OstafinL
Copy link
Contributor

@OstafinL OstafinL commented Dec 20, 2024

🎫 Issue IBX-8962

Description:

!!! PR temporary suspended. Please don't do code review

For QA:

Documentation:

@OstafinL OstafinL added Bug Something isn't working Ready for review labels Dec 20, 2024
@vidarl vidarl self-requested a review December 20, 2024 08:45
Copy link
Contributor

@vidarl vidarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, urls will land in ezurl table encoded.
This will mess up ezurl and ezurl_object_link tables when changing existing links that are not encoded:

  • before patch, create link in richtext: https://ibexa.co/fobar<smokk
  • apply urlencoding
  • edit link in richtext : https://ibexa.co/fobar<smokk2
  • inspect ezurl table and you will find both links there. Also references to https://ibexa.co/fobar<smokk will still be in ezurl_object_link table...

So for this to work fluently:

  • write update script to urlencode all links in ezurl table
  • Fix so that ezurl fieldtype also encode/decode links
  • check that link checker and anything that uses ezurl doesn't break due the fact that urls now are stored encoded. ( I guess things should still work, but not 100%sure)

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, urls will land in ezurl table encoded. This will mess up ezurl and ezurl_object_link tables when changing existing links that are not encoded:

@vidarl true. Let's first minimize impact of the change by encoding only query part after ?. Everything else before that doesn't need to be encoded, so the change won't affect existing URLs without the query part.
ezurl field type would need to be updated accordingly as well.

Then this will go back to the backed and we'll write some upgrade script and see how it behaves after the change.

@OstafinL OstafinL force-pushed the IBX-8962-Unable-to-use-certain-special-characters-in-richtext-links branch 2 times, most recently from 7853537 to ed61c5b Compare December 20, 2024 15:17
@OstafinL OstafinL force-pushed the IBX-8962-Unable-to-use-certain-special-characters-in-richtext-links branch from ed61c5b to 682cd4a Compare January 13, 2025 10:05
@sonarqubecloud
Copy link

@OstafinL OstafinL changed the title IBX-8962: Unable to use certain special characters in richtext links [SUSPENDED] IBX-8962: Unable to use certain special characters in richtext links Jan 15, 2025
@OstafinL OstafinL removed Bug Something isn't working Ready for review labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants