-
Couldn't load subscription status.
- Fork 6
[SUSPENDED] IBX-8962: Unable to use certain special characters in richtext links #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.6
Are you sure you want to change the base?
[SUSPENDED] IBX-8962: Unable to use certain special characters in richtext links #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, urls will land in ezurl table encoded.
This will mess up ezurl and ezurl_object_link tables when changing existing links that are not encoded:
- before patch, create link in richtext:
https://ibexa.co/fobar<smokk - apply urlencoding
- edit link in richtext :
https://ibexa.co/fobar<smokk2 - inspect ezurl table and you will find both links there. Also references to
https://ibexa.co/fobar<smokkwill still be in ezurl_object_link table...
So for this to work fluently:
- write update script to urlencode all links in ezurl table
- Fix so that ezurl fieldtype also encode/decode links
- check that link checker and anything that uses ezurl doesn't break due the fact that urls now are stored encoded. ( I guess things should still work, but not 100%sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, urls will land in ezurl table encoded. This will mess up ezurl and ezurl_object_link tables when changing existing links that are not encoded:
@vidarl true. Let's first minimize impact of the change by encoding only query part after ?. Everything else before that doesn't need to be encoded, so the change won't affect existing URLs without the query part.
ezurl field type would need to be updated accordingly as well.
Then this will go back to the backed and we'll write some upgrade script and see how it behaves after the change.
7853537 to
ed61c5b
Compare
ed61c5b to
682cd4a
Compare
|



Description:
!!! PR temporary suspended. Please don't do code review
For QA:
Documentation: