Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending discounts #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.6
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Extending discounts #2936
Changes from all commits
e542265d10add41eab7aeFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 13 in code_samples/discounts/src/Discounts/PurchaseParityValueFormatter.php
Check failure on line 13 in code_samples/discounts/src/Discounts/PurchaseParityValueFormatter.php
Check warning on line 1 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L1
Raw output
{"message": "[Ibexa.ReadingLevel] The grade level is 12.99. Aim for 8th grade or lower by using shorter sentences and words.", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 1, "column": 1}}}, "severity": "WARNING"}Check warning on line 3 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L3
Raw output
{"message": "[Ibexa.EOLWhitespace] Remove whitespace characters from the end of the line.", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 3, "column": 10}}}, "severity": "WARNING"}Check warning on line 34 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L34
Raw output
{"message": "[Ibexa.EOLWhitespace] Remove whitespace characters from the end of the line.", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 34, "column": 40}}}, "severity": "WARNING"}Check failure on line 36 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L36
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 36, "column": 94}}}, "severity": "ERROR"}Check failure on line 36 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L36
Raw output
{"message": "[Ibexa.DomainTermCapitalization] Use 'SiteAccess' instead of 'siteaccess'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 36, "column": 169}}}, "severity": "ERROR"}Check failure on line 41 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L41
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 41, "column": 76}}}, "severity": "ERROR"}Check failure on line 42 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L42
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 42, "column": 84}}}, "severity": "ERROR"}Check failure on line 42 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L42
Raw output
{"message": "[Ibexa.DomainTermCapitalization] Use 'SiteAccess' instead of 'siteaccess'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 42, "column": 161}}}, "severity": "ERROR"}Check failure on line 43 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L43
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 43, "column": 96}}}, "severity": "ERROR"}Check failure on line 45 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L45
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 45, "column": 82}}}, "severity": "ERROR"}Check failure on line 52 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L52
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 52, "column": 100}}}, "severity": "ERROR"}Check failure on line 54 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L54
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 54, "column": 122}}}, "severity": "ERROR"}Check failure on line 66 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L66
Raw output
{"message": "[Ibexa.Lists] Do not put fullstops at the end of bullets", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 66, "column": 128}}}, "severity": "ERROR"}Check failure on line 82 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L82
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 82, "column": 134}}}, "severity": "ERROR"}Check failure on line 109 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L109
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 109, "column": 126}}}, "severity": "ERROR"}Check failure on line 135 in docs/discounts/extend_discounts.md
[vale] docs/discounts/extend_discounts.md#L135
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts.md", "range": {"start": {"line": 135, "column": 118}}}, "severity": "ERROR"}Check warning on line 1 in docs/discounts/extend_discounts_wizard.md
[vale] docs/discounts/extend_discounts_wizard.md#L1
Raw output
{"message": "[Ibexa.ReadingLevel] The grade level is 15.67. Aim for 8th grade or lower by using shorter sentences and words.", "location": {"path": "docs/discounts/extend_discounts_wizard.md", "range": {"start": {"line": 1, "column": 1}}}, "severity": "WARNING"}Check warning on line 3 in docs/discounts/extend_discounts_wizard.md
[vale] docs/discounts/extend_discounts_wizard.md#L3
Raw output
{"message": "[Ibexa.EOLWhitespace] Remove whitespace characters from the end of the line.", "location": {"path": "docs/discounts/extend_discounts_wizard.md", "range": {"start": {"line": 3, "column": 10}}}, "severity": "WARNING"}Check failure on line 13 in docs/discounts/extend_discounts_wizard.md
[vale] docs/discounts/extend_discounts_wizard.md#L13
Raw output
{"message": "[Ibexa.VariablesGlobal] Use global variable '[[= product_name_base =]]' instead of 'Ibexa'", "location": {"path": "docs/discounts/extend_discounts_wizard.md", "range": {"start": {"line": 13, "column": 76}}}, "severity": "ERROR"}Uh oh!
There was an error while loading. Please reload this page.