IBX-8561: Fixed relation list when trying to display unauthorized content #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
barw4,
wiewiurdp,
GrabowskiM,
tischsoic,
dew326,
OstafinL,
RopRaptor and
albozek
and removed request for
a team
konradoboza
approved these changes
Jun 11, 2025
barw4
approved these changes
Jun 11, 2025
mikadamczyk
approved these changes
Jun 11, 2025
OstafinL
approved these changes
Jun 11, 2025
| 'data-location-id': relation.contentInfo.mainLocationId, | ||
| }, | ||
| 'data-location-id': relation.contentInfo is defined and relation.contentInfo is not null ? relation.contentInfo.mainLocationId, | ||
| }|filter(v => v is not null), |
There was a problem hiding this comment.
Could you use a variable that says something more than v?
dew326
approved these changes
Jun 13, 2025
adamwojs
approved these changes
Jun 19, 2025
barbaragr
force-pushed
the
ibx-8561-unauthorized-relation-list
branch
from
e1df3f8 to
919c834
Compare
|
barbaragr
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During some part of redesign/UX improvment there was added functionality with actions on embedded content. However, non of them took into consideration that we do not always have access to it. As a result, if conditions were not applied to all parts of the view.
For QA:
As the migration do not pass without some modifications - long story short, there is one content with relation to another one placed inside section to which editor user do not have access to.
Documentation: