IBX-10134: Remove depracated JS/twig code #1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
requested review from
tischsoic,
dew326,
OstafinL,
RopRaptor,
albozek and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated JS/Twig code related to handling the extra_actions_after attribute in form fields. The key changes include removing the deprecated assignment and filter for extra_actions_after, and updating the default rendering logic for extra_actions_after in the actions block.
Comments suppressed due to low confidence (1)
src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig:419
- Verify that defaulting extra_actions_after to null is the intended behavior, as the previous fallback to extra_actions_after_from_attr has been removed. Ensure that this change is aligned with the updated API design and consumer expectations.
{{ extra_actions_after|default(null) }}
albozek
approved these changes
Jun 6, 2025
dew326
approved these changes
Jun 9, 2025
OstafinL
approved these changes
Jun 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: