Skip to content

IBX-9060: Revamp notifications #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 96 commits into
base: 4.6
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
b8137fe
IBX-9060: Added renderAllNotificationsPageAction and markNotification…
tbialcz Mar 12, 2025
b510b9e
IBX-9060: Moved pagination rendering to Twig template and simplified …
tbialcz Mar 14, 2025
6ce7874
IBX-9060: Added delete action and delete multiple notifications
tbialcz Mar 26, 2025
c23d494
IBX-9060: notification views changes
albozek Mar 21, 2025
3dd59ad
IBX-9060: Added search form and query support to notifications page
tbialcz Apr 3, 2025
2f7208c
IBX-9060: Fixed modal
dew326 Mar 28, 2025
b327aa2
IBX-9060: Fixed all list
dew326 Mar 31, 2025
a0c2a25
IBX-9060: Added mark all as read
tbialcz Apr 4, 2025
d9ff38a
IBX-9060: Delete, mark as notifications
dew326 Apr 7, 2025
854e2d2
IBX-9060: Mark all as read
dew326 Apr 9, 2025
84153c7
IBX-9060: Fixed notification query parameters to use arrays instead o…
tbialcz Apr 10, 2025
df1c331
IBX-9060: Notification list filter
albozek Apr 24, 2025
bae168d
IBX-9060: Collapsable sidebar
albozek Apr 28, 2025
4ec8845
IBX-9060: Added bulk mark-as-read support and unify selection form ha…
tbialcz Apr 29, 2025
92eaf96
IBX-9060: Added submit buttons to notification selection forms
tbialcz Apr 29, 2025
b3d8ffe
IBX-9060: Refactored routes for marking notifications as read
tbialcz Apr 30, 2025
d2a966d
Refacotr & style fixes
albozek Apr 29, 2025
8b0e7d8
IBX-9060: Moved submit button definition back to SelectionType
tbialcz May 5, 2025
38f9411
IBX-9060: Allowed custom submit button name in NotificationSelectionT…
tbialcz May 5, 2025
3e5b9ab
IBX-9060: Refactored notification query building
tbialcz May 8, 2025
554a121
IBX-9060: Added delete action and delete multiple notifications
tbialcz Mar 26, 2025
de04beb
IBX-9060: Added search form and query support to notifications page
tbialcz Apr 3, 2025
31c8265
IBX-9060: Delete, mark as notifications
dew326 Apr 7, 2025
dfb616f
IBX-9060: Added bulk mark-as-read support and unify selection form ha…
tbialcz Apr 29, 2025
566e5be
IBX-9060: Added submit buttons to notification selection forms
tbialcz Apr 29, 2025
cd72fa9
IBX-9060: Moved submit button definition back to SelectionType
tbialcz May 5, 2025
5ba8873
Mark multiple as read & notification list view expansion
albozek May 5, 2025
1a489f2
Review fixes pt 1
albozek May 6, 2025
7a5dd69
[Behat] Fix for quickReview.feature
May 6, 2025
565fc08
Fixed typo
albozek May 7, 2025
b6e562f
[Behat] Adjusted notification assertion
tomaszszopinski May 7, 2025
19fee17
Style fixes
albozek May 8, 2025
b690b3a
Build fix
albozek May 8, 2025
937cfd6
IBX-9060: Fixed loadNotifications
tbialcz May 9, 2025
814c348
IBX-9060: Fixed POST method
tbialcz May 9, 2025
376a2e4
IBX-9060: Fixed loadNotifications
tbialcz May 9, 2025
6b8752f
Fixed dateRange filter status check
albozek May 9, 2025
15e9289
temp: do not merge
albozek May 9, 2025
820b180
Review fixes pt 2
albozek May 9, 2025
e50b2e1
Review fixes pt 3
albozek May 12, 2025
6bd4ade
Review fixes pt 4
albozek May 14, 2025
1d7ee73
Handled all responses
albozek May 15, 2025
d30f7ad
Merge branch '4.6' into ibx_9060
tbialcz May 20, 2025
5114272
IBX-9060: Specified iterable value types and generic return types to …
tbialcz May 20, 2025
d97cc50
Merge branch '4.6' into ibx_9060
tbialcz Jun 10, 2025
81657b5
IBX-9060: Replaced `loadNotifications` with `findNotifications` in No…
tbialcz Jun 10, 2025
0a79ac1
IBX-9060: Replaced `loadNotifications` with `findNotifications` in No…
tbialcz Jun 10, 2025
4f3d900
Merge remote-tracking branch 'origin/ibx_9060' into ibx_9060
tbialcz Jun 11, 2025
fc2d703
IBX-9060: Added renderAllNotificationsPageAction and markNotification…
tbialcz Mar 12, 2025
94db176
IBX-9060: Moved pagination rendering to Twig template and simplified …
tbialcz Mar 14, 2025
0678434
IBX-9060: Added delete action and delete multiple notifications
tbialcz Mar 26, 2025
154c449
IBX-9060: notification views changes
albozek Mar 21, 2025
b86a717
IBX-9060: Added search form and query support to notifications page
tbialcz Apr 3, 2025
fac92e2
IBX-9060: Fixed modal
dew326 Mar 28, 2025
a644b0b
IBX-9060: Fixed all list
dew326 Mar 31, 2025
3476964
IBX-9060: Added mark all as read
tbialcz Apr 4, 2025
d7fd835
IBX-9060: Delete, mark as notifications
dew326 Apr 7, 2025
bd66f11
IBX-9060: Mark all as read
dew326 Apr 9, 2025
1e83644
IBX-9060: Fixed notification query parameters to use arrays instead o…
tbialcz Apr 10, 2025
d58e399
IBX-9060: Notification list filter
albozek Apr 24, 2025
e847646
IBX-9060: Collapsable sidebar
albozek Apr 28, 2025
f06e4aa
IBX-9060: Added bulk mark-as-read support and unify selection form ha…
tbialcz Apr 29, 2025
49c36f4
IBX-9060: Added submit buttons to notification selection forms
tbialcz Apr 29, 2025
326fea6
IBX-9060: Refactored routes for marking notifications as read
tbialcz Apr 30, 2025
3dac5f5
Refacotr & style fixes
albozek Apr 29, 2025
f5bcd09
IBX-9060: Moved submit button definition back to SelectionType
tbialcz May 5, 2025
7d9a78b
IBX-9060: Allowed custom submit button name in NotificationSelectionT…
tbialcz May 5, 2025
d27b23c
IBX-9060: Refactored notification query building
tbialcz May 8, 2025
f0c79b0
IBX-9060: Added delete action and delete multiple notifications
tbialcz Mar 26, 2025
77ac4ec
IBX-9060: Added search form and query support to notifications page
tbialcz Apr 3, 2025
67d3fc5
IBX-9060: Delete, mark as notifications
dew326 Apr 7, 2025
038c439
IBX-9060: Added bulk mark-as-read support and unify selection form ha…
tbialcz Apr 29, 2025
65a29a5
IBX-9060: Added submit buttons to notification selection forms
tbialcz Apr 29, 2025
86d8afe
IBX-9060: Moved submit button definition back to SelectionType
tbialcz May 5, 2025
6fe292c
Mark multiple as read & notification list view expansion
albozek May 5, 2025
1105893
Review fixes pt 1
albozek May 6, 2025
7065dc3
[Behat] Fix for quickReview.feature
May 6, 2025
b7e0a42
Fixed typo
albozek May 7, 2025
bbee01d
[Behat] Adjusted notification assertion
tomaszszopinski May 7, 2025
279403f
Style fixes
albozek May 8, 2025
8e8bf2e
Build fix
albozek May 8, 2025
136a1e8
IBX-9060: Fixed loadNotifications
tbialcz May 9, 2025
c407d8a
IBX-9060: Fixed POST method
tbialcz May 9, 2025
1a7d4fd
IBX-9060: Fixed loadNotifications
tbialcz May 9, 2025
a86aa31
Fixed dateRange filter status check
albozek May 9, 2025
deda3f9
temp: do not merge
albozek May 9, 2025
19fbcaf
Review fixes pt 2
albozek May 9, 2025
a5dec3d
Review fixes pt 3
albozek May 12, 2025
b21b008
Review fixes pt 4
albozek May 14, 2025
851b20f
Handled all responses
albozek May 15, 2025
865f3b6
IBX-9060: Specified iterable value types and generic return types to …
tbialcz May 20, 2025
8f8cace
IBX-9060: Replaced `loadNotifications` with `findNotifications` in No…
tbialcz Jun 10, 2025
3010f81
IBX-9060: Replaced `loadNotifications` with `findNotifications` in No…
tbialcz Jun 10, 2025
9c60177
Merge branch 'ibx_9060' of https://github.com/ibexa/admin-ui into ibx…
tbialcz Jun 27, 2025
0f96182
IBX-9060: Updated NotificationQuery references and adjusted Notificat…
tbialcz Jun 27, 2025
1b7d447
Changed view all label
albozek Jul 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -726,12 +726,6 @@ parameters:
count: 1
path: src/bundle/Controller/LocationController.php

-
message: '#^Parameter \#1 \$content of class Symfony\\Component\\HttpFoundation\\Response constructor expects string\|null, string\|false given\.$#'
identifier: argument.type
count: 1
path: src/bundle/Controller/NotificationController.php

-
message: '#^Argument of an invalid type array\<Ibexa\\Contracts\\Core\\Repository\\Values\\ObjectState\\ObjectState\>\|null supplied for foreach, only iterables are supported\.$#'
identifier: foreach.nonIterable
Expand Down
28 changes: 28 additions & 0 deletions src/bundle/Controller/AllNotificationsController.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?php

/**
* @copyright Copyright (C) Ibexa AS. All rights reserved.
* @license For full copyright and license information view LICENSE file distributed with this source code.
*/
declare(strict_types=1);

namespace Ibexa\Bundle\AdminUi\Controller;

use Ibexa\Contracts\AdminUi\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class AllNotificationsController extends Controller
{
public function renderAllNotificationsPageAction(Request $request, int $page): Response
{
return $this->forward(
NotificationController::class . '::renderNotificationsPageAction',
[
'page' => $page,
'template' => '@ibexadesign/account/notifications/list_all.html.twig',
'render_all' => true,
]
);
}
}
Loading
Loading