Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #77

Merged
merged 19 commits into from
Sep 1, 2020
Merged

Bug fixes #77

merged 19 commits into from
Sep 1, 2020

Conversation

fabcodingzest
Copy link
Collaborator

Fixes #issuenumber

What type of PR is this?

  • 🚀 Added Feature
  • 🐛 Fixed Bug
  • 📝 Docs Update
  • 🚩 Other

Check everything

  • I have added the issue number for which this pull request is created.
  • I have selected the TradeByte Project in Projects

Description

  • Fixed the flash message issue
  • Implemented Client-side form validation for both sign in and sign up.
  • Added a pattern for a password.
  • Limited the addBalance amount and prevented stripe from executing.
  • Added a layout for pages without navbar as simple-page and coded done, error 404, and 500 pages.
  • Done page mobile-layout issue fixed.
  • Cleaned CSS and improved the UI bugs.
  • Improved and formatted the overall code.

@fabcodingzest
Alerts regarding Login moved to landing page
0de8764
@fabcodingzest
input limit applied to cart
9a97391
@fabcodingzest
Edit form input set to required to avoid 500 error
20db480
@fabcodingzest
profit bug fixed
acda827
@fabcodingzest
Merge branch 'master' of https://github.com/iampavangandhi/TradeByte …
cffb3e5 
…into bug-fixes
@fabcodingzest
Done page improved adn added simple pg layout
ee35d47
@fabcodingzest
Error 404 page done
e857534
@fabcodingzest
fix in view page on medium screen
23c75c0
@fabcodingzest
Error page 500 done
bafee35
@fabcodingzest
Merge branch 'master' of https://github.com/iampavangandhi/TradeByte …
52b5607 
…into bug-fixes
@fabcodingzest
minor change in 500 error page
ee21cd7
@fabcodingzest
formatted and cleaned the code
7be420a
@fabcodingzest
changed classname to icon from notification
24b2089
@fabcodingzest
Style changes
879fdfe
@fabcodingzest
Added links for contact and improved testimonials
daa6bb8
@fabcodingzest
Client side Form Validation done on both sign in & sign up with patte…
fb24a68 
…rn in password
@fabcodingzest
sign in form don't need validation so removed it
7c859b8
@fabcodingzest
Limited addBalance amount and stopped stripe PG
88087e1
@fabcodingzest
fixed the signup margin issues to prevent scroll
901c49d
@fabcodingzest fabcodingzest added bug Something isn't working enhancement New feature or request frontend Frontend Task backend Backend Task labels Sep 1, 2020
@fabcodingzest fabcodingzest merged commit c17a10d into iampavangandhi:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Backend Task bug Something isn't working enhancement New feature or request frontend Frontend Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabcodingzest