New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-16 #24

Closed

howdyAnkit wants to merge 2 commits into iampavangandhi:master from howdyAnkit:feature-add-alphavantageMarket-stocks

Collaborator

howdyAnkit commented Aug 7, 2020 •

edited

Loading

Fixes #16

🚀 Added Feature
🐛 Fixed Bug
🚩 Other

Check everything

I have added the issue number for which this pull request is created.
I have selected the TradeByte Project in Projects

Description

The requested pull is for getting the real-time live stocks from alpha vantage API


          alphaVantage live market stocks update

4e19145

hound bot reviewed

View reviewed changes

routes/api/view.js

+                      .catch((err) => {
+                          // Handle the error
+                          console.log(err);
+                      });

hound bot Aug 7, 2020

Unrecoverable syntax error. (95% scanned).

routes/api/view.js

+                                  }
+                              );
+                      })
+                      .catch((err) => {

hound bot Aug 7, 2020

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

routes/api/view.js

+                                      closing,
+                                      highs,
+                                      lows,
+                                      volumes

hound bot Aug 7, 2020

'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                                      opening,
+                                      closing,
+                                      highs,
+                                      lows,

hound bot Aug 7, 2020

'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                                      dates,
+                                      opening,
+                                      closing,
+                                      highs,

hound bot Aug 7, 2020

'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                          let closing = [];
+                          let highs = [];
+                          let lows = [];
+                          let volumes = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                          let opening = [];
+                          let closing = [];
+                          let highs = [];
+                          let lows = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                          let dates = [];
+                          let opening = [];
+                          let closing = [];
+                          let highs = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                          const intraDay = data["Time Series (1min)"];
+                          let dates = [];
+                          let opening = [];
+                          let closing = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                      .then((data) => {
+                          const intraDay = data["Time Series (1min)"];
+                          let dates = [];
+                          let opening = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).


          alphaVantage live market stocks update

c01c532

hound bot reviewed

View reviewed changes

routes/api/view.js

+                      .intraday(symbol)
+                      .then((data) => {
+                          const intraDay = data["Time Series (1min)"];
+                          let dates = [];

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                  alpha.data
+                      .intraday(symbol)
+                      .then((data) => {
+                          const intraDay = data["Time Series (1min)"];

hound bot Aug 7, 2020

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+                  alpha.data
+                      .intraday(symbol)
+                      .then((data) => {

hound bot Aug 7, 2020

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

routes/api/view.js

+              // @access   Private
+              router.get("/:symbol", ensureAuth, async (req, res) => {
+                  const symbol = req.params.symbol;
+                  let data = await getOverview(symbol);

hound bot Aug 7, 2020

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

routes/api/view.js

+              // @route    GET /view/:symbol
+              // @access   Private
+              router.get("/:symbol", ensureAuth, async (req, res) => {
+                  const symbol = req.params.symbol;

hound bot Aug 7, 2020

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Expected ')' and instead saw 'req'.
Expected ')' to match '{' from line 17 and instead saw 'symbol'.
Expected an assignment or function call and instead saw an expression.
Expected an identifier and instead saw '='.
Expected an identifier and instead saw 'const' (a reserved word).

routes/api/view.js

+                  key: process.env.ALPHA_VANTAGE_KEY
+              });
+              const getOverview = require("../../helpers/getOverview");

hound bot Aug 7, 2020

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+              //jshint esversion:8
+              const express = require("express");
+              const router = express.Router();
+              const alpha = require("alphavantage")({

hound bot Aug 7, 2020

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

+              // View Routes
+              //jshint esversion:8
+              const express = require("express");
+              const router = express.Router();

hound bot Aug 7, 2020

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

@@ @@ -0,0 +1,67 @@ @@
+              // View Routes
+              //jshint esversion:8
+              const express = require("express");

hound bot Aug 7, 2020

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

routes/api/view.js

		@@ -0,0 +1,67 @@
		// View Routes
		//jshint esversion:8

hound bot Aug 7, 2020

Bad option value.

howdyAnkit assigned iampavangandhi

howdyAnkit added add feature enhancement labels

howdyAnkit added this to the Week 1 milestone

howdyAnkit closed this

howdyAnkit deleted the feature-add-alphavantageMarket-stocks branch

August 9, 2020 10:02

howdyAnkit assigned howdyAnkit and unassigned iampavangandhi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add feature enhancement