Skip to content

Conversation

@NoB0
Copy link
Collaborator

@NoB0 NoB0 commented Dec 13, 2023

Implement endpoints to add and delete statements.

@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Unit Test Results

63 tests   63 ✔️  8s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 5f15c71.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Coverage Report •
FileStmtsMissCoverMissing
conftest.py00100% 
pkg_api
   connector.py350100% 
pkg_api/server
   \_\_init\_\_.py30388%36–38
   pkg_exploration.py260100% 
   statements_management.py31487%35–36, 60–61
   utils.py39582%82–85, 102, 112
tests/pkg_api/server
   conftest.py13094%25–>24
   test_statement_management.py330100% 
TOTAL12945793% 

@github-actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

@NoB0 NoB0 linked an issue Dec 15, 2023 that may be closed by this pull request
@NoB0 NoB0 marked this pull request as ready for review March 6, 2024 16:56
@NoB0 NoB0 requested a review from WerLaj as a code owner March 6, 2024 16:56
Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments about docstrings

element_data: Union[Dict[str, Any], str]
) -> TripleElement:
"""Parses a triple element received from HTTP request.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raises block missing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method does not raise any exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add endpoint for population via form

2 participants