-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate some replaced metadata methods and improve metadata API #7783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to have eslint-disable-next-line @typescript-eslint/no-deprecated
in our owned code. I'll try to find some time to update it this week.
Hey, that's a fair point. I want to improve the messages on those deprecation warnings to point to the replacement. But I realized that our replacements are much more verbose which I don't like. I will do a follow up story to provide better drop-in replacements, shortcuts, or make other API improvements to ease the transition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed changes under presentation
dir & NextVersion.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just that one typo.
…injs-core into rob/deprecate-metadata
This pull request is now in conflicts. Could you fix it @rschili? 🙏 |
Hey @aruniverse @hl662 @christophermlawson could you give this another look? Thanks |
This pull request is now in conflicts. Could you fix it @rschili? 🙏 |
I replaced some callers with the new calls, and ignored the deprecation warning on others. Eventually we will want to replace them all.
Deprecated methods/types
Common package:
Backend package
Also made the following (breaking) changes to ecschema-metadata:
See Nextversion.md for a more comprehensive list of changes.
There are several new shortcuts and helper method that make transitioning easier.
Parent: https://github.com/iTwin/itwinjs-backlog/issues/1156
Part of: https://github.com/iTwin/itwinjs-backlog/issues/1415