-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drape model map layers onto reality models #7637
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…-core into drape-onto-reality
References to specific formats have been removed. |
This pull request is now in conflicts. Could you fix it @markschlosseratbentley? 🙏 |
This PR adds support to iTwin.js for draping model map layers onto reality data.
A new property titled
drapeTarget
has been added to ModelMapLayerProps and ModelMapLayerSettings. When this property is specified asModelMapLayerDrapeTarget.RealityData
, the model map layer will be only draped onto all attached reality data. Supported reality data formats include glTF or b3dm. IfdrapeTarget
is not specified in the properties, it will default toModelMapLayerDrapeTarget.BackgroundMap
, which will only drape the model map layer onto the background map.TODO:
TODO (Future PRs):
pipes_draped_onto_reality_model_off
ingeolocated_pipes.bim
is not rendering the draping in DPTA (Image Tests). It is rendering in display-test-app locally. Investigating. The other draping saved views work in DPTA (Image Tests). Issue: In DPTA only, draping onto reality data does not work when the model-being-draped is disabled #7818Here is an example of draping a model from within an iModel (the piping in the air) onto some glTF reality data (the terrain underneath):

Here is an example of the same dataset as above with the model itself disabled, so you only see the draping onto the glTF reality data:

To test locally, you can open display-test-app and:
fdt attach model maplayer reality
while an element is selected - the model associated with that element will drape onto the reality model.