Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codepen demos #2432

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix codepen demos #2432

merged 1 commit into from
Feb 11, 2025

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Feb 11, 2025

Changes

This fixes the broken CodePen demos by updating the React version to 19. This was made possible by the recent release (#2417).

Explanation: After some investigation, I found that the issue was that CodePen was somehow loading two different versions of React. This might have been caused by the https://esm.sh CDN using the latest compatible React version for dependencies, or due to CodePen (being a browser-based tool) not correctly resolving "peer dependencies", or a combination of both. Either way, switching to React 19 makes it work correctly.

Testing

Verified that the CodePen demos render correctly, both locally and in the deploy preview. No more console errors.

Docs

N/A

@mayank99 mayank99 self-assigned this Feb 11, 2025
@mayank99 mayank99 marked this pull request as ready for review February 11, 2025 20:45
@mayank99 mayank99 requested a review from a team as a code owner February 11, 2025 20:45
@mayank99 mayank99 requested review from r100-stack and smmr-dn and removed request for a team February 11, 2025 20:45
@r100-stack r100-stack removed the request for review from smmr-dn February 11, 2025 21:41
Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mayank99 mayank99 merged commit 712a588 into main Feb 11, 2025
18 checks passed
@mayank99 mayank99 deleted the mayank/codepen-demos branch February 11, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants