DrivewayTransitions in OpenSite.01.00.05 #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -143,10 +143,6 @@ | |||
|
|
|||
| <ECEntityClass typeName="DrivewayMidVertex" modifier="Sealed" displayLabel="Driveway Mid Vertex" description="Vertex of a DrivewayPath that is attached to two DrivewayPathEdge instances."> | |||
| <BaseClass>PathMidVertex</BaseClass> | |||
|
|
|||
| <ECProperty propertyName="SideTransitionOffset" typeName="double" kindOfQuantity="rru:LENGTH" category="DrivewayMidVertex_Transition" displayLabel="Transition Offset" description="The transition offset distance." /> | |||
There was a problem hiding this comment.
You can't delete properties - this is a breaking change, see https://www.itwinjs.org/bis/guide/schema-evolution/schema-versioning-and-generations/#minor-schema-upgrades
There was a problem hiding this comment.
We probably want to hide these properties and mark them as deprecated.
| <Class class="DrivewayTransition" /> | ||
| </Target> | ||
| </ECRelationshipClass> | ||
|
|
There was a problem hiding this comment.
I don't think we want to make a change and immediately release a new Schema version - we need to test this schema first. I think normally, you make changes to the WIP (work in progress) schema, new dev version of this schema is published to NPM, we test it, perhaps make adjustments, and then we make a release PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DrivewayTransition entity class with some of the properties formerly found in the DrivewayMidVertex, and a relationship class between the two.