Add more flexibility for minimum ground speed #10720
Draft
+233
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added overriding min ground speed to the programming framework. - Added reading min ground speed to the programming framework. - Updated nav functions to get the min ground speed via the programming framework. This handles if the override is enabled or not. - Added min ground speed element to the OSD. This involved re-formatting `osdFormatVelocityStr` to take a `osd_speedTypes_e` value. Instead or adding another boolean to define speed types. Moved Airspeed variants in to the function too. **Todo** - [ ] Add getting wind speed to programming framework - [ ] Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more flexibility to minimum ground speed. Access has been added to the programming framework for retrieval and override. An example use would be setting the min ground speed to be x km/h above the wind speed.
osdFormatVelocityStrto take aosd_speedTypes_evalue. Instead or adding another Boolean to define speed types. Moved Airspeed variants in to the function too. I think it's a neater and more futureproof solution.Todo